Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Plasma deposits #1217

Open
wants to merge 23 commits into
base: eth-blockchain
Choose a base branch
from
Open

Plasma deposits #1217

wants to merge 23 commits into from

Conversation

mederic-p
Copy link
Contributor

@mederic-p mederic-p commented Nov 16, 2020 •
edited
Loading

Issue/Task Number: #1194
Closes #1194

Overview

Refactor deposit to OMG network using ALD contracts.

Changes

  • Use ex_plasma to build deposit transactions
  • Add rust to CI steps and doc to be able to build ex_plasma deps
  • Use ALD deposit vault contracts (changed from single contract that was used before)

Mederic added 16 commits November 12, 2020 17:34
@kalouo
Copy link

kalouo commented Nov 24, 2020

I know this is still a draft, but – in case – don't forget to add that installing Rust is a requirement in the relevant .md docs.

Also, the versions of Rust in the Dockerfile and in .tool-versions seem different?

@mederic-p mederic-p marked this pull request as ready for review December 8, 2020 08:41
kalouo
kalouo reviewed Dec 8, 2020
View reviewed changes
apps/ewallet/lib/ewallet/gates/transactions/blockchain_gate.ex Outdated
@@ -43,6 +43,7 @@ defmodule EWallet.TransactionGate.Blockchain do
@deposit_transaction Transaction.deposit()

@rootchain_identifier BlockchainHelper.rootchain_identifier()
@token_cofirmed EWalletDB.Token.Blockchain.status_confirmed()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo cofirmed

kalouo
kalouo reviewed Dec 8, 2020
View reviewed changes
Copy link

@kalouo kalouo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also after trying it out from the admin panel)

T-Dnzt
T-Dnzt approved these changes Mar 11, 2021
View reviewed changes
Copy link

@T-Dnzt T-Dnzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@nicholasmueller
Copy link
Contributor

lgtm too! 🚀 merge it!

@kalouo
Copy link

kalouo commented Mar 11, 2021

hahaha

@jarindr
Copy link
Contributor

jarindr commented Mar 11, 2021

approved, best PR in the HISTORY.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalouo kalouo kalouo left review comments

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@jarindr jarindr jarindr approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mederic-p @kalouo @nicholasmueller @jarindr @T-Dnzt